Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Migrate e2e tests: try explicitly killing processes before setting up new cluster #17394

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Flaky Migrate e2e tests: try explicitly killing processes before setting up new cluster #17394

wants to merge 1 commit into from

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

There has been a lot of flakiness in the e2e VReplication Migrate tests. Each of the ones I checked had a process not starting because a previous one had not been stopped. This happened even for the first test in the CI workflow. So possibly this is happening from previous workflows in reused test VMs or there is a bug somewhere in our cluster management.

Trying explicitly pkilling the processes a test cluster creates to see if we can work around this.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Try explicitly killing processes started during the tests to see if i…
09901da 
…t fixes the flakiness seen by some residual processes, especially in the migrate tests

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 15, 2024
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Testing Flakes and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 15, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Dec 15, 2024
rohit-nayak-ps
rohit-nayak-ps commented Dec 15, 2024
View reviewed changes
go/test/endtoend/vreplication/cluster_test.go
cmd := exec.Command("pkill", fmt.Sprintf(".*%s.*", bin))
err := cmd.Run()
if err != nil {
log.Infof("Error killing %s: %v", bin, err)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log lines are for checking if we have residual processes. If this works we can remove the log lines asap.

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (45192d2) to head (09901da).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17394   +/-   ##
=======================================
  Coverage   67.52%   67.53%           
=======================================
  Files        1581     1581           
  Lines      253948   253948           
=======================================
+ Hits       171480   171499   +19     
+ Misses      82468    82449   -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: VReplication Flakes Type: Testing
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rohit-nayak-ps